Skip to content

carbsReq pushover improvements #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scottleibrand merged 68 commits into from
Jun 14, 2022
Merged

carbsReq pushover improvements #1421

scottleibrand merged 68 commits into from
Jun 14, 2022

Conversation

@scottleibrand
Copy link
Contributor

@scottleibrand scottleibrand commented Jan 15, 2022

This PR cuts down on spurious/duplicate carbsReq pushover noise:

  • don't send carbsReq alerts if COB is zero due to clock data parsing error
  • run pushover from pump-loop immediately after completing a loop
  • check Nightscout for pushover snoozes (created when another rig has already sent a pushover) immediately before sending one

The latter two combine to eliminate the race condition where two rigs would both send pushover alerts if they completed loops within a minute or two of each other (before cron had a chance to run pushover, update the snooze file to Nightscout, and then run ns-loop to download it to the other rig).

@scottleibrand
comment out shared-node cp to avoid full disk
1cb2a8a
@scottleibrand
Merge branch 'dev' of github.com:openaps/oref0 into dev
fd11713
@scottleibrand
Merge branch 'dev' of github.com:openaps/oref0 into dev
487c385
@scottleibrand
don't send carbsReq alerts if COB is zero due to clock data parsing e…
627045d 
…rror
@scottleibrand
run pushover in pump-loop
255ee9b
@scottleibrand
run pushover in pump-loop
c14d655
@scottleibrand
check pushover_snooze immediately before sending a pushover
f3f288c
@scottleibrand
pathfix
8212690
@scottleibrand
run pushover in pump-loop instead of cron-every-minute
b374277
@scottleibrand
don't background pushover for now
99fb042
@scottleibrand
uncomment debug line
2a32aad
@scottleibrand
debugging
87a991d
@scottleibrand
debugging
2d1b32f
@scottleibrand
debugging
d504e5d
@scottleibrand
-e to make jq return non-zero if no snooze found
b2fea0f
@scottleibrand
apparently this line never worked
1823b2e
@scottleibrand
comment out debug line
641372f
@scottleibrand
no newline
4a0f2f0
@scottleibrand
don't print date
f9f680e
@scottleibrand
remove extra logging
2c31224
@scottleibrand
fix check for empty MAKER_KEY
67f6999
@scottleibrand
only print snooze message if there's something to snooze
76ee85a
@scottleibrand
don't print contents of file
8d6cf9c
@scottleibrand
update Pushover Glances to include temp basal rate*duration
4d950eb
@scottleibrand
direction arrows
4acab54
@scottleibrand
U/h
dcb26f3
@scottleibrand
use NS to coordinate glances snoozes between rigs
343f52c
@scottleibrand
more compact carbsreq string
c90904e
@scottleibrand
make glanceDelay configurable
964e2dd
@scottleibrand
better check of whether pushoverGlances is a number
cf7e13f
@scottleibrand
Revert "NS uses UTC now"
a755e09 
This reverts commit e9f8810.
@scottleibrand
convert NS UTC date into local time
f1944bf
@scottleibrand
don't print
116197a
@scottleibrand
comment out debug lines
51fd708
@scottleibrand
don't print snooze.json, just the fact we uploaded one
38b72e5
@scottleibrand
check that glance api returns status: 1
cff7baf
@scottleibrand
don't print snooze.json
060f1ac
@scottleibrand
just print the fact we sent a carbsReq pushover
2a282db
@scottleibrand
don't print meal.json (twice)
5b832da
@scottleibrand
less verbose logging after wait_for_silence
51f85c8
@scottleibrand
don't print
549f49a
@scottleibrand
check that pushover api returns status: 1
3e47ba9
@scottleibrand
spacing
3ae2348
@scottleibrand
just print COB after refreshing meal.json
bcac13f
@scottleibrand
less verbose logging
62557b3
@scottleibrand
print entirer meal.json, colorized
952e024
@scottleibrand
remove duplicate cat of meal.json
48c4d0e
@scottleibrand
add delta to glance title
7469243
@scottleibrand
print last_glance time inline
bcbdfb1
@scottleibrand
display tick instead of delta
1938971
@scottleibrand
tick before arrow
4ef34aa
@scottleibrand
remove quotes
8e7d712
@scottleibrand
retry w/o new BG after failure to parse clock data
5c894e2
@scottleibrand
don't use grep -q to avoid return code 141 race condition
6219216
@scottleibrand
don't use grep -q to avoid return code 141 race condition
11d9cd8
@scottleibrand
don't use grep -q to avoid return code 141 race condition
5c913a3
@Foxy7
Copy link
Contributor

Foxy7 commented Jan 19, 2022

@scottleibrand these changes look good, do you need them testing?

@scottleibrand
Copy link
Contributor Author

scottleibrand commented Jan 19, 2022

I think they are ready for broader testing, yes. We have been using this branch on all our rigs and it’s looking good so far. Have kept the PR open until I stop finding more things to fix. :-)

@scottleibrand scottleibrand merged commit da7015c into dev Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scottleibrand @Foxy7